search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Remove releaseTags from cocina-models #721

Closed aaron-collier closed 5 months ago

aaron-collier commented 5 months ago

Fixes #714 by removing the releaseTags from openapi.yml and it's uses.

Validation and migrations have been run.

NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.

Why was this change made? 🤔

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

aaron-collier commented 5 months ago

@justinlittman - Good catch, I honestly just missed it because it didn't come up when grepping for releaseTag. However, it makes me wonder that if the model is being used by purl-fetcher, wouldn't we still need this in the api spec and validation?

I think this should be held until we decide on remediation and maybe this purl-fetcher use in any case.

Thanks.

jcoyne commented 5 months ago

Purl-fetcher does not use Cocina::Models::ReleaseTag

justinlittman commented 5 months ago

Looks like Argo and DSA do.

aaron-collier commented 5 months ago

Looks like it's used in hydra_etd as well. Hydra_etd already has DSC as a dependency so I should easily be able to update that. But based on our deploy repos, I think those are the only locations it's used.