sul-dlss / common-accessioning

Suite of robots that handle the tasks of accessioning digital objects
Other
2 stars 1 forks source link

add extra logging around deletes/move XML result cleanup #1309

Closed peetucket closed 1 week ago

peetucket commented 2 weeks ago

Why was this change made? 🤔

  1. Trying to learn more about why files/folders do not seem to get deleted sometimes.
  2. Code normalization for consistency.
  3. Move Result XML file cleanup to the cleanup step when the file is no longer needed (reverting from #1311)

How was this change tested? 🤨

QA and rspec

peetucket commented 1 week ago

Output folder sometimes doesn't get removed, and when I tried deleting one on the server it complained "it wasn't empty" even though it looked empty and even though I was using rm -rf ... and then after a few tries, it was deleted. So possibly a weird file system issue.