sul-dlss / common-accessioning

Suite of robots that handle the tasks of accessioning digital objects
Other
2 stars 1 forks source link

Remove the invocation of jobs in accessionWF:end-accession #1322

Open peetucket opened 3 months ago

peetucket commented 3 months ago

See https://github.com/sul-dlss/common-accessioning/issues/1289#issuecomment-2197469689

We have a race condition that is manifested by a potentially long running job invoked by accessionWF:end-accession. It would be better to not have the job invoked there, but instead by a previous step in accessionWF. We already have a previous step called reset-workspace that seems to do similar related cleanup work. This would be a good candidate to move the CleanupJob too (and possibly combine with ResetWorkspaceJob).

This would be a pre-req: sul-dlss/dor-services-app#5110

Per Captioning work cycle planning meeting 2024-09-25: This warrants a quick check-in with the wider infra team about whether to proceed, and much (maybe most) of the work will be coordinating testing. Also, we think that maybe the retries (in DSA job?) will keep the race condition from bothering Andrew with failed workflow steps, but not totally sure about that?