search

sul-dlss / component-library

Reference implementation of components for DLSS
https://sul-dlss.github.io/component-library/
0 stars 0 forks source link

Update palette.css #28

Closed dnoneill closed 3 months ago

jcoyne commented 3 months ago

Argo has a section of colors that are no in the component library. Perhaps you could do something like this: https://github.com/sul-dlss/argo/blob/main/app/assets/stylesheets/variables.css#L2-L9

dnoneill commented 3 months ago

Is there a reason why not? I am thinking it would be nice to have all the standard Stanford colors set in one place so we don't have to keep updating them in different apps. Maybe we shouldn't but I see value in having all the colors standardized and in on place.

jcoyne commented 3 months ago

All the colors all the variants rgb + hex seems like a lot of css and it may not ever be used. This would make it harder to maintain because we don't know if or where any of these things may be used. I think a minimal set could be better.

dnoneill commented 3 months ago

Good point. We are going to use this for earthworks but I see your point.