sul-dlss / dlme-transform

Transforms raw DLME metadata to DLME intermediate representation
Apache License 2.0
0 stars 2 forks source link

Transformation errors after gem update #209

Closed jacobthill closed 5 years ago

jacobthill commented 5 years ago

There are transformation errors with 3 datasets since the gem update: 'cambridge', 'penn', and 'stanford'. Not sure if they are related. Running transformations locally on each of the collections should reproduce the errors. Let me know if there are any issues reproducing the errors. The penn error may be related to https://github.com/sul-dlss/dlme-transform/issues/161

aaron-collier commented 5 years ago

@jacobthill can you include some of the error information you're seeing so we can verify what we see locally?

Thank you.

jacobthill commented 5 years ago

I’m away from my computer until tomorrow but as I recall penn was an error related to tie_config, stanford was related to mods_config and cambrige was a dry validation error. I’ll post the actual error messages in the morning

jacobthill commented 5 years ago

stanford error: [ERROR] Error loading configuration file config/mods_config.rb:28 ArgumentError:wrong number of arguments (given 2, expected 1) /usr/local/bundle/gems/traject-3.2.0/lib/traject/indexer.rb:231:in `rescue in block in load_config_file': Error loading configuration file config/mods_config.rb:28 ArgumentError:wrong number of arguments (given 2, expected 1) (Traject::Indexer::ConfigLoadError)

penn error: [ERROR] Error loading configuration file config/tei_config.rb:46 ArgumentError:wrong number of arguments (given 2, expected 1) /usr/local/bundle/gems/traject-3.2.0/lib/traject/indexer.rb:231:in `rescue in block in load_config_file': Error loading configuration file config/tei_config.rb:46 ArgumentError:wrong number of arguments (given 2, expected 1) (Traject::Indexer::ConfigLoadError)

cambridge error: [ERROR] Transform produced invalid data. The errors are: [#<Dry::Schema::Message text="must be filled" path=[:agg_is_shown_at, :wr_id] predicate=:filled? input="">, #<Dry::Schema::Message text="must be filled" path=[:agg_preview, :wr_id] predicate=:filled? input="">]}

aaron-collier commented 5 years ago

Thanks @jacobthill. It appears that this may all be related to the issues @mjgiarlo is discussing in channel. Hopefully we'll get this addressed quickly.

jacobthill commented 5 years ago

I think the penn and stanford errors are related to what @mjgiarlo is working on; I think the cambridge errors are caused by something else.

aaron-collier commented 5 years ago

Oh yeah, that's the dry work that @ndushay is working through. Should be addressed soon. Thank you for the detail.

ndushay commented 5 years ago

penn:

[ERROR] Transform produced invalid data.

The errors are: [#<Dry::Schema::Message text="must be a string" path=[:agg_is_shown_at, :wr_id] predicate=:str? input=nil>, #<Dry::Schema::Message text="must be a string" path=[:agg_preview, :wr_id] predicate=:str? input=nil>]}

stanford:

The errors are: [#<Dry::Schema::Message text="is missing" path=[:agg_is_shown_by, :wr_has_service, 0, :service_id] predicate=:key? input={"service_conforms_to"=>["http://iiif.io/api/image/"], "service_id"=>"https://stacks.stanford.edu/image/iiif/cm881bj1960%2FW705_000001_300", "service_implements"=>"http://iiif.io/api/image/2/level2.json"}>, #<Dry::Schema::Message text="is missing" path=[:agg_is_shown_by, :wr_has_service, 0, :service_conforms_to] predicate=:key? input={"service_conforms_to"=>["http://iiif.io/api/image/"], "service_id"=>"https://stacks.stanford.edu/image/iiif/cm881bj1960%2FW705_000001_300", "service_implements"=>"http://iiif.io/api/image/2/level2.json"}>, #<Dry::Schema::Message text="is missing" path=[:agg_preview, :wr_has_service, 0, :service_id] predicate=:key? input={"service_conforms_to"=>["http://iiif.io/api/image/"], "service_id"=>"https://stacks.stanford.edu/image/iiif/cm881bj1960%2FW705_000001_300", "service_implements"=>"http://iiif.io/api/image/2/level2.json"}>, #<Dry::Schema::Message text="is missing" path=[:agg_preview, :wr_has_service, 0, :service_conforms_to] predicate=:key? input={"service_conforms_to"=>["http://iiif.io/api/image/"], "service_id"=>"https://stacks.stanford.edu/image/iiif/cm881bj1960%2FW705_000001_300", "service_implements"=>"http://iiif.io/api/image/2/level2.json"}>]}

also stuff like this ...

E, [2019-09-26T22:24:01.273546 #8] ERROR -- : IIIF Manifest not found: Unexpected response type 'text/html; charset=utf-8' for https://purl.stanford.edu/18020021/iiif/manifest
...
E, [2019-09-26T22:24:01.500964 #8] ERROR -- : IIIF Manifest not found: Unexpected response type 'text/html' for https://purl.stanford.edu/bh691yj7263/iiif/manifest
...
E, [2019-09-26T22:24:01.578567 #8] ERROR -- : IIIF Manifest not found: Unexpected response type 'text/html' for https://purl.stanford.edu/bm840kw7224/iiif/manifest
ndushay commented 5 years ago

I can confirm that we have worked through the dependency update issues both for [traject, traject_plus] and for [dry-schema, dry-validation]