sul-dlss / dlme

Digital Library of the Middle East web application, based on Spotlight
https://dlmenetwork.org/
Other
20 stars 2 forks source link

Hide the "Sign in" link in the site brandbar #1372

Closed ggeisler closed 1 year ago

ggeisler commented 2 years ago

This could be low priority but it also might be relatively easy and would improve the user experience on the (admittedly rare) occasions when a user selects the "Sign in" link the top-right of the site brandbar.

There are several improvements that could be made when selecting the "Sign in" link:

Current "sign in" page ("sign up" is basically the same)

Screen Shot 2021-12-15 at 5 03 34 PM

Suggested updates

Screen Shot 2021-12-15 at 5 28 18 PM

If we do the above, we should also update the "Sign up" page, since the changes could be pretty much identical (add masthead, add alert box with the same text):

Screen Shot 2021-12-15 at 5 33 08 PM
mwerla commented 2 years ago

@ggeisler I think that if the login/sign up option is not applicable to end users, we should remove that from the public UI. Those few who use that function can simply bookmark the link.

ggeisler commented 2 years ago

@mwerla Sure, hiding the Sign in link would be even better. I was concerned that the team would not like the idea of having to bookmark/keep track of the Sign in URL, but if we're okay with that, just hiding the link would be simpler than updating the sign in and sign up pages.

If we go this route, we should make sure to use a technique that hides the Sign link both visually and from screen readers, such as adding a hidden attribute to the Sign in element (or I think styling it with display: none would be functionally equivalent).

Also, if we go this route, I would still love to see the step of "Add the DLME masthead to the page" for the sign in/sign up pages, because those pages feel clunky to me without the masthead and the availability of the accompanying main menu items. But since only DLME team members would ever see those pages, I recognize this is likely a very low priority.