search

sul-dlss / dlme

Digital Library of the Middle East web application, based on Spotlight
https://dlmenetwork.org/
Other
19 stars 2 forks source link

Allow URIs as resource ids #336

Closed jacobthill closed 5 years ago

jacobthill commented 5 years ago

All of the BnF data uses urls for resource ids; I believe we need a Macro to hash these

anarchivist commented 5 years ago

Acceptance criteria:

Test data is the current BnF data

jcoyne commented 5 years ago

Tracking https://github.com/projectblacklight/spotlight/issues/2140

aaron-collier commented 5 years ago

Having deployed @jcoyne's branch, the BnF data seems work fine but not the Sakip Sabanci data: https://spotlight.stage.dlmenetwork.org/library/catalog/http:%2F%2Fdigital.sabanciuniv.edu%2Fabidindino%2Fmektup%2F3040200001541.pdf

jcoyne commented 5 years ago

@aaron-collier that request would be asking the rails server for a PDF representation for that resource. That's a case that I hadn't anticipated..

jacobthill commented 5 years ago

@jcoyne @aaron-collier https://github.com/sul-dlss/dlme-transform/issues/111 with solve this issue.

jcoyne commented 5 years ago

@jacobthill That issue isn't listed as part of the current project. Should it be?

jacobthill commented 5 years ago

Yes, I just added it.

jcoyne commented 5 years ago

Fixed by #473