search

sul-dlss / dlss-wowza

Wowza server side modules.
1 stars 0 forks source link

Encode spaces in file names with %20 not + #28

Closed jkeck closed 8 years ago

jkeck commented 8 years ago

The path segment of a URI should not have their spaces encoded as a + (and use a %20 instead) since rfc3986 does not indicate that + should be handled in any special way (other than literally as a +). This is unlike URL query parameters which specifies that spaces are to be replaced by +.

We should change the file name portion of the verify_token request to encode spaces as %20 and not + which will be handled by the verification code properly.

jmartin-sul commented 8 years ago

there are issues in practice, possibly due to not deploying new dependencies for the plugin

ndushay commented 8 years ago

SAR-3198 asks for help in figuring out how to deploy the guava and commons-validator jars.

ndushay commented 8 years ago

See #30 for jar deployment work

ndushay commented 8 years ago

31 was PR to build a tar containing dlss-wowza jar and its dependencies. That has been merged, a new release was done and I confirmed it worked afterwards. I updated the jenkins build to create the tar, and it works (the tar is now the artifact). SAR-3198 has the details of what needs to happen to puppet code to get this deployable.

ndushay commented 8 years ago

SAR-3198 has been taken care of (thanks @kamchan ); this fix has been deployed to -stage. Perhaps the only thing that remains is for @jmartin-sul to affirm that media files with spaces and pluses in the file names work???

ndushay commented 8 years ago

Seems to be an improvement. Closing in favor of sul-dlss/sul-embed#578.

ndushay commented 8 years ago

(for reference, see: https://consul.stanford.edu/display/chimera/Character+set+constraints+for+SDR+file+names )