search

sul-dlss / dor-services-app

A Rails application exposing Digital Object Registry functions as a RESTful HTTP API
https://sul-dlss.github.io/dor-services-app/
Other
3 stars 2 forks source link

Inline indexing code. #4929

Closed justinlittman closed 6 months ago

justinlittman commented 6 months ago

Why was this change made? 🤔

Reduce complexity. Indexing is now only performed in DSA.

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

Unit, integration tests

justinlittman commented 6 months ago

My concern with your proposal is that "builders" is a generic term that we use fairly inconsistently; without the context of "indexing" it is unclear what sort of builders these are.

I'm not opposed to a subsequent re-organization of the code of avoid the junk drawer, but I'd suggest that it be kept clear what is indexing code.