since technical-metadata-service's database only tracks preserved files, filter non-preserved files from the list we send to techMD service for auditing
re-ran the full report on QA. got 142 results instead of the 369 returned before this change.
ran the techMD rake task techmd:generate_for_moab for a druid in the new result list, and saw it get remediated (job got queued and executed in techMD service, audit detected no error when re-run after that).
confirmed that non-preserved file names were no longer fed to techMD's audit endpoint. e.g. for druid:wy216td0310 on QA, i originally got the result druid:wy216td0310: found technical-metadata-service database; inconsistencies with v1 cocina: {"missing_filenames"=>["example.jp2"]}. but after this change, the non-preserved example.jp2 was no longer sent to techMD, and the audit then detected no errors for that druid (before this change logs showed auditing {:druid=>"druid:wy216td0310", :file_list=>[{:filename=>"example.tiff", :md5=>"7c35bef13c1fdc201ff0c93a42085bc8"}, {:filename=>"example.jp2", :md5=>"8ff299eda08d7c506273840d52a03bf3"}]}, and after this change they showed auditing {:druid=>"druid:wy216td0310", :preserved_file_list=>[{:filename=>"example.tiff", :md5=>"7c35bef13c1fdc201ff0c93a42085bc8"}]}, and logged a response like druid:wy216td0310: audited technical-metadata-service; response status: 200; response body: {"missing_filenames":[],"unexpected_filenames":[],"mismatched_checksum_file_infos":[]}).
confirmed that percent complete messages still show up in the logs
âš¡ âš If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡
Why was this change made? 🤔
Dro, since we've gotten rid of that model (follow on from https://github.com/sul-dlss/dor-services-app/pull/5013)part of https://github.com/sul-dlss/technical-metadata-service/issues/515
How was this change tested? 🤨
techmd:generate_for_moabfor a druid in the new result list, and saw it get remediated (job got queued and executed in techMD service, audit detected no error when re-run after that).druid:wy216td0310on QA, i originally got the resultdruid:wy216td0310: found technical-metadata-service database; inconsistencies with v1 cocina: {"missing_filenames"=>["example.jp2"]}. but after this change, the non-preservedexample.jp2was no longer sent to techMD, and the audit then detected no errors for that druid (before this change logs showedauditing {:druid=>"druid:wy216td0310", :file_list=>[{:filename=>"example.tiff", :md5=>"7c35bef13c1fdc201ff0c93a42085bc8"}, {:filename=>"example.jp2", :md5=>"8ff299eda08d7c506273840d52a03bf3"}]}, and after this change they showedauditing {:druid=>"druid:wy216td0310", :preserved_file_list=>[{:filename=>"example.tiff", :md5=>"7c35bef13c1fdc201ff0c93a42085bc8"}]}, and logged a response likedruid:wy216td0310: audited technical-metadata-service; response status: 200; response body: {"missing_filenames":[],"unexpected_filenames":[],"mismatched_checksum_file_infos":[]}).percent completemessages still show up in the logsâš¡ âš If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡