search

sul-dlss / dor-services-app

A Rails application exposing Digital Object Registry functions as a RESTful HTTP API
https://sul-dlss.github.io/dor-services-app/
Other
3 stars 2 forks source link

Stop asking workflow service to close version. #5049

Closed justinlittman closed 3 months ago

justinlittman commented 3 months ago

closes #5047

Why was this change made? 🤔

The versioningWF now only has one step and that step is completed, so no need to close.

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

Unit, stage integration

justinlittman commented 3 months ago

No, it was intentional. In the past, the way to close a version was to tell the workflow service to end all of the steps in the versioningWF. After doing that it also kicked off the accessioningWF.

Now, we no longer need to end all of the steps in the versioningWF and DSA is responsible for kicking off accessioningWF.