search

sul-dlss / dor-services-app

A Rails application exposing Digital Object Registry functions as a RESTful HTTP API
https://sul-dlss.github.io/dor-services-app/
Other
3 stars 2 forks source link

Set resourceType to an empty string for Datacite if it's nil #5102

Closed aaron-collier closed 3 weeks ago

aaron-collier commented 3 weeks ago

Why was this change made? 🤔

This avoids including the option resourceType in the datacite package if it is nil.

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

mjgiarlo commented 3 weeks ago

@aaron-collier Approved. Might be worth adding a test or it might not depending on how the tests are currently written and how much work it'd add to this PR.