sul-dlss / dor-services-app

A Rails application exposing Digital Object Registry functions as a RESTful HTTP API
https://sul-dlss.github.io/dor-services-app/
Other
3 stars 2 forks source link

Combine reset workspace and cleanup job logic #5110

Open peetucket opened 2 weeks ago

peetucket commented 2 weeks ago

We currently have two different jobs called ResetWorkspace and Cleanup that do similar things, calling out to ResetWorkspaceService and CleanupService. These jobs are invoked by DSA, which in turn starts then via calls from accessionWF:reset-workspace and accessionWF:end-accession.

It may make sense to have a single job that does combines the logic of these two cleanup steps, and then invoke this single job from accessionWF:reset-workspace and remove the invocation of the job from accessionWF:end-accession, so that there are no jobs being called from the last step in accessionWF.

Reasoning? See the logic here: https://github.com/sul-dlss/common-accessioning/issues/1289#issuecomment-2197469689

Would also possibly require changes to dor-services-client if any endpoints change in DSA.

See also sul-dlss/common-accessioning#1322