search

sul-dlss / earthworks

Geospatial discovery application for Stanford University Libraries.
https://earthworks.stanford.edu
Other
18 stars 3 forks source link

Pin faraday >= 2 #970

Closed thatbudakguy closed 1 year ago

thatbudakguy commented 1 year ago

This removes the downstream dependency on patron, which needs cURL headers in order to build correctly on Ubuntu machines.

The missing headers cause issues on both GitHub CI runners (https://github.com/actions/runner-images/issues/37) and our automated deploys (https://sul-ci-prod.stanford.edu/job/SUL-DLSS/job/earthworks/job/master/56/display/redirect).

thatbudakguy commented 1 year ago

blocked on #969 which includes faraday 2 compatibility; will rebase when that is merged rebased

cbeer commented 1 year ago

I think code like: https://github.com/sul-dlss/earthworks/blob/629a5dd2c336dece626baa751f829489a06034f8/scripts/geoserver/update_caching.rb#L18

isn't 2.x compatible, is it (also used in other scripts files)?

thatbudakguy commented 1 year ago

Hmm, I didn't know about any of those files in scripts. From a cursory glance, it seems like they are similar to tasks that @kimdurante does manually right now (like updating GeoWebCache for a layer). The OGP related stuff we no longer need, since we're not committing to maintain that old data anymore (per discussion with GIS team).

I could see about making them faraday 2.x compatible if it's just a matter of changing those basic_auth calls. Do you know anything else about these scripts?

thatbudakguy commented 1 year ago

ok, I was able to just change basic_auth to set_basic_auth in the 4 scripts that use it, and confirm that at least one of the scripts executed fine this way. maybe that's good enough?