sul-dlss / exhibits

Stanford University Libraries online exhibits showcase
https://exhibits.stanford.edu
Other
19 stars 7 forks source link

Empty index values creating empty links (Copyright Renewals) #1763

Open jvine opened 4 years ago

jvine commented 4 years ago

Empty facet value at the top of the Author facet: https://exhibits.stanford.edu/copyrightrenewals

It's possible for a keyboard or SR user to trigger this link: https://exhibits.stanford.edu/copyrightrenewals/catalog?f%5Bauthor_person_facet%5D%5B%5D=

Empty titles at top of search results - https://exhibits.stanford.edu/copyrightrenewals/catalog?utf8=%E2%9C%93&exhibit_id=copyrightrenewals&search_field=search&q=

again, keyboard/SR can trigger: https://exhibits.stanford.edu/copyrightrenewals/catalog/R458196

I'm not sure how this should be fixed - data remediation? If the metadata is accurate (can it be??) then the app needs to handle empty values in a way that makes them perceivable.

These haven't been reported for any other exhibit, so hopefully it's not a broader problem.

Tagging @caaster for attention.

cbeer commented 4 years ago

I think these blank values will go away with a reindex.

mejackreed commented 4 years ago

@caaster is it ok if I go ahead and reindex?

cbeer commented 4 years ago

Don't bother with copyrightrenewals; I'll be doing something to it for #1759

corylown commented 1 month ago

Need to determine whether this is still an issue.

There are still 13,829 records in the copyrightrenewals exhibit that have an empty string in the author_person_facet. The comments on this issue suggest a re-index might resolve the issue, but it does not appear that the exhibit has been re-indexed. A full re-index may be the first thing to try to resolve this.

Solr query to find these records:

exhibits_prod/query?q=*:*&q.op=OR&indent=true&fl=id,author_person_facet&fq=spotlight_exhibit_slugs_ssim:copyrightrenewals&fq=author_person_facet:""
caaster commented 1 month ago

@hannahfrost question from Cory: he would like to reindex this exhibit to see if that fixes the problem. Is it ok for him to reindex?

hannahfrost commented 1 month ago

Yes, fine to reindex. Thanks!

— Hannah Frost | Associate Director for Digital Services Stanford Librarieshttps://library.stanford.edu/ | Digital Library Systems and Services Lathrop Library 384 E: @.*** | C: (650) 799-1352 Pronouns: she/her

On Jul 23, 2024, at 7:57 AM, Cathy Aster @.***> wrote:

@hannahfrosthttps://github.com/hannahfrost question from Cory: he would like to reindex this exhibit to see if that fixes the problem. Is it ok for him to reindex?

— Reply to this email directly, view it on GitHubhttps://github.com/sul-dlss/exhibits/issues/1763#issuecomment-2245486913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANXW5EORVJJEH52ZZ7YD3DZNZVNDAVCNFSM6AAAAABLDCTXMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGQ4DMOJRGM. You are receiving this because you were mentioned.Message ID: @.***>

corylown commented 1 month ago

I am going to need more information about where the records for this collection come from. They have no corresponding resource in the database that I can find and therefore cannot be reindexed.