search

sul-dlss / exhibits

Stanford University Libraries online exhibits showcase
https://exhibits.stanford.edu
Other
19 stars 7 forks source link

Remove houndci #2481

Closed corylown closed 2 days ago

corylown commented 1 month ago

The exhibits repo has houndci set up so that it flags/comments in places where there are linting violations in javascript and scss. We'd like to be able to use more recent JS without it getting flagged, such as in this PR: https://github.com/sul-dlss/exhibits/pull/2474

However, by default houndci uses jshint to lint javascript and it only supports jshint 2.9.5 (see http://help.houndci.com/en/articles/2461415-supported-linters), which is 7 years old and can't be configured to allow ES2020 (or anything newer than ES6).

It's possible we could switch it to use eslint instead which it supports up to 8.1.0 (released 3 years ago). But given that it's so behind on linter versions I'm questioning whether this is viable tool for us to use.

corylown commented 1 month ago

Draft PR that switches to eslint: https://github.com/sul-dlss/exhibits/pull/2480

corylown commented 1 month ago

Decision from access team: remove houndci. It pre-dates our use of rubocop.