search

sul-dlss / exhibits

Stanford University Libraries online exhibits showcase
https://exhibits.stanford.edu
Other
20 stars 7 forks source link

adding fields for searching for exhibits: pub_display and ref_type_ssm #2597

Closed hudajkhan closed 1 month ago

hudajkhan commented 1 month ago

Relates to #2054 .

What this PR does: pub_search was already being added to pub_display, and we want pub_display to also be searchable. This pull request populates pub_search with the journal and publisher info from bibtex as well as place info from dor configuration. Schema.xml already includes a directive to copy pub_search to pub_display. This enables searching across all the values that will be in pub_display.

The PR also copies ref_type_ssm to ref_type_ssim. Schema.xml copies all *_ssim fields to all_search, so the values in this field will also be searchable.

A few tests relied on pub_display values. Since the code populates pub_search (and the schema leads to copying of this field to pub_display), the PR updates those tests to use pub_search instead.

dnoneill commented 1 month ago

I think you want to do this in the indexer not the schema. i.e. https://github.com/sul-dlss/exhibits/pull/2551/files, so put pub_display into another field that gets indexed already by the schema.

hudajkhan commented 1 month ago

@dnoneill To keep it in the code and not in the schema directly? ok I can try that instead.

hudajkhan commented 1 month ago

Any _search is automatically added to all_search so I can try that. On the other hand, there is a pub_search field too but problematically that is copied TO pub_display [Actually, turns out dynamic fields for _search are not included so I was wrong about this]