search

sul-dlss / folio_client

Interface for interacting with the Folio ILS API.
Other
0 stars 0 forks source link

Check whether instance has cataloged status #13

Closed lwrubel closed 1 year ago

lwrubel commented 1 year ago

Why was this change made? 🤔

Fixes #7 to add method to be used by hydra_etd.

How was this change tested? 🤨

Unit

lwrubel commented 1 year ago

@ndushay would calling the method has_instance_status? be clearer?

I was using argument forwarding with the public method, which passes them on to the Inventory class methods, following the pattern we've been using in globus_client and folio_client so far. Let me know if it's clearer to handle this method differently, however.

ndushay commented 1 year ago

approved - merge (and release gem) at will. Thanks for considering all the comments.