Constants are part of the interface, and exceptions are referenced outside the UnexpectedResponse context, so I figure it makes more sense for these to be defined where they may be referenced without knowledge of implemention details (namely, the UnexpectedResponse class).
Also, rename the redundant FolioClient::FolioClientError to FolioClient::Error.
NOTE: This will be a breaking change for any consumer that directly references these error classes.
Why was this change made? 🤔
Constants are part of the interface, and exceptions are referenced outside the
UnexpectedResponsecontext, so I figure it makes more sense for these to be defined where they may be referenced without knowledge of implemention details (namely, theUnexpectedResponseclass).Also, rename the redundant
FolioClient::FolioClientErrortoFolioClient::Error.NOTE: This will be a breaking change for any consumer that directly references these error classes.
How was this change tested? 🤨
CI