search

sul-dlss / folio_client

Interface for interacting with the Folio ILS API.
Other
0 stars 0 forks source link

Add method to `JobStatus` class for retrieving an instance HRID #35

Closed mjgiarlo closed 1 year ago

mjgiarlo commented 1 year ago

Why was this change made? 🤔

Fixes #12

This commit adds a new method, JobStatus#instance_hrid, that allows consumers to request retrieval of the instance HRID associated with the current job status as long as the status has already successfully completed. If not, a Failure() is returned. And if there is any trouble parsing an instance HRID out of the journal records of the job execution, a Failure() is returned indicating such.

How was this change tested? 🤨

mjgiarlo commented 1 year ago

@lwrubel Hi, do you have advice on how I could test this change against a Folio instance? I assume we've done a bit of that before on API changes.

lwrubel commented 1 year ago

I haven't yet tested the folio_client against the live APIs myself, but I believe @justinlittman has been doing this with his local code.

mjgiarlo commented 1 year ago

@lwrubel 💬

I haven't yet tested the folio_client against the live APIs myself, but I believe @justinlittman has been doing this with his local code.

OK, thanks! @justinlittman When you get a minute, would you mind writing this up or pairing?