Add missing test coverage and update/tidy Rubocop - Githubissues

sul-dlss / folio_client

Interface for interacting with the Folio ILS API.

Other

0 stars 0 forks source link

Add missing test coverage and update/tidy Rubocop #58

Closed mjgiarlo closed 1 year ago

mjgiarlo commented 1 year ago

Why was this change made? 🤔

Routine tidying and bringing coverage back up

Includes:

Stop using Rubocop TODOs (there are and were zero of them)
Allow RSpec examples to be up to 15 lines long (to accommodate our more verbose specs)
Add new Rubocop cops
Add test for ValidationError in UnexpectedResponse

How was this change tested? 🤨

CI