sul-dlss / gis-robot-suite

Robots for GIS accessioning and delivery
Other
9 stars 4 forks source link

[spike] try adding reload method, retries, and timeout configuration to samvera-labs/geoserver-publish gem #797

Open jmartin-sul opened 8 months ago

jmartin-sul commented 8 months ago

If this works out, this is the longer term fix we'd prefer for the timeout issue that was ticketed by https://github.com/sul-dlss/gis-robot-suite/issues/786 (fixed within this codebase by https://github.com/sul-dlss/gis-robot-suite/pull/791).

Changes we'd like to try pushing upstream are something like:

And then depending on which of the above changes are pushed upstream and accepted, upgrade gis-robot-suite to the new gem version and take advantage of the new functionality (e.g. get rid of the retries gem and in-robot retry handling for reload calls, use the #reload method instead of POSTing more directly to the reload path, set a longer timeout for the reload call). For our testing, we could point gis-robot-suite's Gemfile to our WIP branch of the gem, though. Might be a good idea to make some of the gem changes, use them in the robots, see if it makes the gem look more useful and the robots more maintainable, and proceed if both of those things check out?

Totally fine to break spin off new and more specific tickets for subtasks in this ticket, if that feels more reasonable (but please update this ticket to indicate that the subtask is now tracked in the new ticket).

jmartin-sul commented 8 months ago

Useful faraday-retry examples: