search

sul-dlss / happy-heron

Self-Deposit for the Stanford Digital Repository (SDR): H2 is a Rails web application enabling users to deposit scholarly content into SDR
Apache License 2.0
10 stars 2 forks source link

Ignore mac Icon files. #3483

Closed justinlittman closed 2 months ago

justinlittman commented 3 months ago

closes #3477

Why was this change made? 🤔

Files are not necessary and clutter things up.

How was this change tested? 🤨

âš¡ âš  If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. âš¡

Unit, Andrew.

Does your change introduce accessibility violations? 🩺

âš¡ âš  Please ensure this change does not introduce accessibility violations (at the WCAG A or AA conformance levels); if it does, include a rationale. See the Infrastructure accessibility guide for more detail. âš¡

mjgiarlo commented 2 months ago

@justinlittman @jmartin-sul Still on hold or is this shippable?

jmartin-sul commented 2 months ago

@justinlittman @jmartin-sul Still on hold or is this shippable?

Guessing (vaguely recalling) that the hold was for testing by Andrew. No other reason I can think of to hold.