sul-dlss / happy-heron

Self-Deposit for the Stanford Digital Repository (SDR): H2 is a Rails web application enabling users to deposit scholarly content into SDR
Apache License 2.0
10 stars 2 forks source link

Fix autogen citation disabled bug #3537

Closed aaron-collier closed 1 month ago

aaron-collier commented 1 month ago

Why was this change made? 🤔

Quick fix for #3529 - there is a bug in the citation code that adds a space to the string if the dot is empty and therefore the values no longer match and the autogen button is disabled incorrectly.

How was this change tested? 🤨

Verified in stage and prod (using the item in the ticket)

âš¡ âš  If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. âš¡

Does your change introduce accessibility violations? 🩺

âš¡ âš  Please ensure this change does not introduce accessibility violations (at the WCAG A or AA conformance levels); if it does, include a rationale. See the Infrastructure accessibility guide for more detail. âš¡