I have found three issues with versioning of items in collections with the review workflow on and am able to replicate them all. They are all documented in this one ticket, since it's not clear to me whether they are part of the same problem or different problems.
The three issues are described below, along with the easiest way to replicate the problem.
For an item in a collection with the review workflow on and where that item is being versioned:
Once that item is submitted for approval, if the reviewer opens it to make changes, the reviewer does not see the versioning question. The entire box is missing from the form.
Desired behavior: Reviewer should also see the versioning question box on the form so they can make sure the correct option was selected.
To replicate:
Create your own item in a collection with the review workflow on, submit it for approval, and then approve it so it completes deposit. Then start a new version and submit it for approval. OR FASTER: use an existing item that is pending approval such as https://sdr.stanford.edu/works/8670.
Go to the item view page.
You're now functioning as the reviewer -- click the pencil icon to open up the form.
You will not see the versioning questions box at the top of the form, but you should
If the depositor made changes to the file section of the form for the new version, AND the reviewer opens the item and then saves it as a draft or submits it for approval -- whether they make any changes to the form or not -- all the depositor's changes to the file section of the form are lost.
Desired behavior: When the reviewer edits an item submitted for approval, changes made by the depositor to the file section should persist, unless changed by the reviewer, when the reviewer clicks either "save as draft" or "submit for approval" instead of reverting back to the last version state.
To replicate:
Create your own item in a collection with the review workflow on, submit it for approval, and then approve it so it completes deposit.
Then start a new version. Be sure to 1) choose the "yes" option for versioning and 2) make a change to the file section of the form.
Submit the item for approval.
Go to the item view page.
You're now functioning as the reviewer -- click the pencil icon to open up the form.
Scroll to the bottom and select either "save as draft" or "submit for approval". Same thing happens either way. Also, the same thing happens to the files whether you make any changes to the form or not.
On the view page you'll see that the file changes made by the "depositor" have been wiped out.
Regardless of what the depositor chooses as the response to the versioning question, if the item is returned to them for changes, the versioning section displays "no" as the chosen response and the "what's changing" comments that were entered show up in the box associated with the "no" response. This means "yes" selections are being converted to "no" inappropriately.
Desired behavior: Versioning box should always reflect what the user previously selected.
To replicate:
Create your own item in a collection with the review workflow on, submit it for approval, and then approve it so it completes deposit.
Then start a new version. Be sure to choose the "yes" option for versioning.
Submit the item for approval.
Go to the item view page.
You're now functioning as the reviewer -- return the item to the depositor.
You're now functioning as the depositor -- go to the item view page and open the item for editing.
You'll see that versioning section now has the "no" option selected, even though you'd originally chosen "yes."
I'll note that the second issue is preventing Stella from being able to update the file on this thesis as she needs to do. She does not have a hard deadline on getting the change made, but this is a significant problem that I think should be addressed soon.
I have found three issues with versioning of items in collections with the review workflow on and am able to replicate them all. They are all documented in this one ticket, since it's not clear to me whether they are part of the same problem or different problems.
The three issues are described below, along with the easiest way to replicate the problem.
For an item in a collection with the review workflow on and where that item is being versioned:
Desired behavior: Reviewer should also see the versioning question box on the form so they can make sure the correct option was selected.
To replicate:
Desired behavior: When the reviewer edits an item submitted for approval, changes made by the depositor to the file section should persist, unless changed by the reviewer, when the reviewer clicks either "save as draft" or "submit for approval" instead of reverting back to the last version state.
To replicate:
Desired behavior: Versioning box should always reflect what the user previously selected.
To replicate:
I'll note that the second issue is preventing Stella from being able to update the file on this thesis as she needs to do. She does not have a hard deadline on getting the change made, but this is a significant problem that I think should be addressed soon.