search

sul-dlss / happy-heron

Self-Deposit for the Stanford Digital Repository (SDR): H2 is a Rails web application enabling users to deposit scholarly content into SDR
Apache License 2.0
10 stars 2 forks source link

Upgrade to Rails 7.2 #3635

Closed aaron-collier closed 1 month ago

aaron-collier commented 1 month ago

Why was this change made? 🤔

Upgrade to rails 7.2

How was this change tested? 🤨

âš¡ âš  If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. âš¡

Does your change introduce accessibility violations? 🩺

âš¡ âš  Please ensure this change does not introduce accessibility violations (at the WCAG A or AA conformance levels); if it does, include a rationale. See the Infrastructure accessibility guide for more detail. âš¡

aaron-collier commented 1 month ago

@sul-dlss/infrastructure-team - Note that @mjgiarlo and I walked through this and it seems clear that the current expectation is that ActiveStorage libraries live in lib . We believe the coverage drop is a red herring based on moving the code as it's obviously used in existing tests.