sul-dlss / libsys-airflow

Airflow DAGS for migrating and managing ILS data into FOLIO along with other LibSys workflows
Apache License 2.0
5 stars 0 forks source link

Create connection details in Airflow Connections #1023

Closed jgreben closed 5 months ago

jgreben commented 5 months ago
shelleydoljack commented 5 months ago

connection_id pod created on dev/stage/prod.

shelleydoljack commented 5 months ago

connection_id sharevde created on dev/stage/prod.

shelleydoljack commented 5 months ago

connection_id gobi created on dev/stage/prod.

shelleydoljack commented 5 months ago

@jermnelson Maybe we can pair on this for OCLC? I see the data in vault at puppet/application/libsys_airflow/oclc but I'm not entirely sure how the connection data was modeled as you tested it locally. There isn't a test for transmit_data_oclc_api_task that mocks the connection details and I can't quite tell how the task called from the dag and the connection details are parsed out for each library.

This is what I did on dev but it doesn't seem right: https://sul-libsys-airflow-dev.stanford.edu/connection/edit/70

jermnelson commented 5 months ago

Hi @shelleydoljack, happy to pair on this; looking at the http-web.oclc-SUL connection you created seems correct. I haven't tested this beyond instantiating an instance of the OCLC API class based on the connection's credentials running Airflow locally.

shelleydoljack commented 5 months ago

Ahh, ok. I'll keep going with what I created and add a test. :)

shelleydoljack commented 5 months ago

OCLC connections for GSB, MED, LANE, LAW, SUL created in airflow dev/stage/prod.