sul-dlss / libsys-airflow

Airflow DAGS for migrating and managing ILS data into FOLIO along with other LibSys workflows
Apache License 2.0
5 stars 0 forks source link

Are the new funds really being passed to digital_bookplate_instances DAG? #1314

Closed shelleydoljack closed 1 month ago

shelleydoljack commented 1 month ago

I'm skeptical that the digital_bookplate_instances DAG is getting the funds from the conf / params of the previous DAG fetch_digital_bookplates. When I review the Task Instance Details for a recent run that was triggered by adding new bookplates to the table https://sul-libsys-airflow-dev.stanford.edu/task?dag_id=digital_bookplate_instances&task_id=start&execution_date=2024-10-18T22%3A08%3A48.794993%2B00%3A00&map_index=-1 I see only logical_date in the params. Here is a screenshot of the ti details for the invoices_paid_within_date_range task: Screenshot 2024-10-22 at 11 48 56 AM And for the same dag run, here are the task details for bookplate_polines_funds mapped task 0: Screenshot 2024-10-22 at 11 50 06 AM Related to #1312 If it is not getting the funds list, the task should just query to table for all of the funds so maybe not a big deal.

shelleydoljack commented 1 month ago

Yes, the funds list is passed from fetch_digital_bookplates to digital_bookplate_instances. Here is a screenshot of a recent test run on airflow-dev: Screenshot 2024-10-24 at 1 53 11 PM The Run config shows what config was passed, which is in the dag run params, which we can't see in the airflow UI (at least I haven't been able to find it). In the log for the date_range_or_funds_path task branch, you can see the INFO line for fund: Screenshot 2024-10-24 at 1 56 16 PM