sul-dlss / libsys-airflow

Airflow DAGS for migrating and managing ILS data into FOLIO along with other LibSys workflows
Apache License 2.0
5 stars 0 forks source link

Return True unless False for testing whether tag is unique #1359

Closed jgreben closed 4 weeks ago

jgreben commented 4 weeks ago

The default return for FolioAddMarcTags.__tag_is_unique__ was False :-/ Also, adds some extra logging.

https://sul-libsys-airflow-dev.stanford.edu/dags/digital_bookplate_979/grid?dag_run_id=manual__2024-10-24T23%3A14%3A06.651308%2B00%3A00&task_id=add_marc_tags_to_record&tab=logs

https://folio-test.stanford.edu/inventory/view/b0fc4cdb-8271-5c14-90b5-648a19e4c7f7?qindex=id&query=b0fc4cdb-8271-5c14-90b5-648a19e4c7f7&sort=title

shelleydoljack commented 4 weeks ago

Checked the record in folio-test and see this:

999 | f f | ‡i b0fc4cdb-8271-5c14-90b5-648a19e4c7f7 ‡s 3412ee18-b79d-5363-ab3c-7388823c4797
979 |   | ‡d The Donald P. Abbott Fund for Marine Invertebrates
shelleydoljack commented 4 weeks ago

Checked the record in folio-test and see this:

999 | f f | ‡i b0fc4cdb-8271-5c14-90b5-648a19e4c7f7 ‡s 3412ee18-b79d-5363-ab3c-7388823c4797
979 |   | ‡d The Donald P. Abbott Fund for Marine Invertebrates

I'm addressing this in a different PR.