search

sul-dlss / libsys-webforms

Rails applications for various Symphony reporting & updating tools.
1 stars 2 forks source link

Remove ability to manage (create/edit) Sal3 batch requests if mgt_rpts has a value. #1196

Closed shelleydoljack closed 11 months ago

shelleydoljack commented 11 months ago

I tested this by nulling out sal3_batch_req and sal3_breq_edit but leaving mgt_rpts with values A and Y and tried to create a sal3 batch request in prod. I was able to create/edit requests with mgt_rpts A or Y but not if mgt_rpts = null. If we want people to be able to still create management reports but not Sal3 batch requests, then we should probably remove this line for ability.rb.

shelleydoljack commented 11 months ago

:( ugh tests are failing b/c our dependencies are outdated, i think. Maybe just update the file on prod server for now???

dlrueda commented 11 months ago

Maybe we don’t need to do this. If users end up submitting requests, the job that processes them is suspended. We can delete them and recreate in the new FOLIO way. I’m ok doing this PR (if we can get checks to pass) but maybe we don’t need to spend time on it? And we’re going to have to re-instate everyone’s access later in any case.