search

sul-dlss / mods

A Ruby gem to parse MODS (Metadata Object Description Schema) records.
Other
10 stars 6 forks source link

Shouldn't from_str() return self also? #15

Closed atz closed 9 years ago

atz commented 9 years ago

https://github.com/sul-dlss/mods/blob/master/lib/mods/record.rb#L33 https://github.com/sul-dlss/mods/blob/master/lib/mods/record.rb#L73

That's from_str and from_nk_node, respectively.

The other from_* methods both return self. These two should at least document/specify what they return, probably uniformly with the others.