search

sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.
Other
2 stars 5 forks source link

Display related items when they are expressed in a <note> element within the <relatedItem> element #106

Closed andrewjbtw closed 2 years ago

andrewjbtw commented 2 years ago

Show related items when they are encoded using the following structure, which is how self-deposits have been encoding related items since the launch of H2:

<relatedItem>
      <note type="preferred citation">Sarah Beller, 401 Forbidden: An Empirical Study of Foreign Intelligence Surveillance Act Notices, 1990-2020, 13 Harv. Nat'l Security J. 158 (2021)</note>
</relatedItem>

This request is based on discussion in https://jirasul.stanford.edu/jira/browse/SW-4088 following feedback from depositors who weren't sure why the related items they entered were not being displayed.

Additional context

The previous self-deposit application, which had a different entry form design, appears to have nested a <title> element under <relatedItem>. When related items are encoded that way, they do appear in the Purl and SW display. The current deposit app prompts people to enter full citations for their related items, which is why there's been a change to using a note field.

amyehodge commented 2 years ago

I've had another depositor requesting that the publications related to their data deposit -- which they entered in the metadata -- show up on the PURL page. This was a large data deposit for Nik Martelaro (now at Carnegie Mellon) and Wendy Ju (now at Cornell). The item is https://purl.stanford.edu/gj863qr6417. The related publications are clearly visible only in the xml for the page.

amyehodge commented 2 years ago

Depositor Gert van Dijken also reported to me that his related works entries on https://purl.stanford.edu/kc822vj3040 were not showing up. He checked older deposits and found they were not showing up on those either.

thatbudakguy commented 2 years ago

@amyehodge thanks for pointing out that this fix wasn't in production — we had neglected to make sure purl was picking up the new version of mods_display. can you confirm it's working now?

amyehodge commented 2 years ago

Yes! All three of the instances I have are working perfectly. Thanks for following up on this. My users will be happy. :)