search

sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.
Other
2 stars 5 forks source link

Replace BC/AD with BCE/CE #116

Closed saseestone closed 2 years ago

saseestone commented 2 years ago

For mods dates, we need to replace BC and AD with BCE/CE

arcadiafalcone commented 2 years ago

Examples: Single AD date: dm212rn7381 966 A.D. > 966 CE

Single BC date: I could not find an example in production, but taking the first date in the range from tw991mx3953 ca. 250 B.C. > ca. 250 BCE

Date ranges have additional issues ticketed in #117 .

thatbudakguy commented 2 years ago

fixes for this have been applied to stanford-mods and mods_display. i also checked purl, exhibits, searchworks and the traject indexer to confirm there wasn't any other logic out there dealing with it. changes should go live on 7/18 when we push out dependency updates.

saseestone commented 2 years ago

@thatbudakguy will records need to be reindexed to see the fix in SW? I'm assuming yes, but a confirmation would be super.

cbeer commented 2 years ago

Yes, at least for some places these dates show up in searchworks.

thatbudakguy commented 2 years ago

also, just to note — there may still be places B.C./A.D. show up if it was written into the record that way. these fixes just apply to places where we're generating the display ourselves, i.e. there was a date like "800" and so we applied "CE" instead of "A.D." to it. when we find those, we can remediate them in the data if we need to.

thatbudakguy commented 2 years ago

dm212rn7381 and tw991mx3953 are now showing dates in BCE, so closing.