search

sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.
Other
2 stars 5 forks source link

Display of date ranges for years before 0 #117

Closed arcadiafalcone closed 2 years ago

arcadiafalcone commented 2 years ago

See also #116 for changing current use of B.C./A.D. to BCE/CE.

In MODS date ranges where the end date is less than 0, the value is not parsed for display. It should be transformed in the same way as the start date.

Example: tw991mx3953 [ca. 250 B.C.--0099] > [ca. 250 BCE-100 BCE]

cbeer commented 2 years ago

What happens if

<dateCreated qualifier="approximate" point="end">-0099</dateCreated>

also has encoding="edtf"?

arcadiafalcone commented 2 years ago

@cbeer I think it should still display the same as the first date.

cbeer commented 2 years ago

I've confirmed the date range displays correctly with encoding="edtf".

arcadiafalcone commented 2 years ago

So the issue is that the first date has encoding="edtf" and the second does not? I know we changed how the modsulator handles encoding for endpoints of date ranges at some point so that may have introduced some inconsistency. I'll look into data remediation to add the encoding to the second date.

cbeer commented 2 years ago

Correct. I think any encoding would work, but unencoded dates are too ambiguous to parse 🤷‍♂️

arcadiafalcone commented 2 years ago

OK, I'll treat this as a data issue then. Closing.