sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.
Other
2 stars 5 forks source link

Support line breaks in use and reproduction statements #145

Closed thatbudakguy closed 9 months ago

thatbudakguy commented 10 months ago

proposal

see this issue in the requirements doc

n.b. this requires upstream work (https://github.com/sul-dlss/happy-heron/issues/3404) in order to separate the statements with a line break in the underlying metadata; they are currently concatenated without one.

see: https://github.com/sul-dlss/mods_display/blob/3c6be0f84a08b1f723908b5fc6ae836d888f9212/app/helpers/mods_display/record_helper.rb#L90-L94

in purl, we currently use the link_urls_and_email helper to do...what it says, so that should be applied automatically.

example item with user-provided statement, concatenated onto default statement: https://purl.stanford.edu/fg611qq0508

example item that uses "abstract" field instead, because their custom statement couldn't be correctly formatted: https://purl.stanford.edu/jw293pc3297

user stories

As a depositor or collection manager, I want the custom use statement that I include to be distinct from the standard use and reproduction statement that appears on all PURLs so that users are more likely to see the additional terms required.

As a depositor publishing an Open Access article, I want the custom use statement that I include to support hyperlinks so that I can fully meet the requirements of my publisher, which may include providing a custom use statement with a link that works.

related to #78.

andrewjbtw commented 10 months ago

Some notes for context within the SDR writ large:

I want the custom use statement that I include to be distinct from the standard use and reproduction statement that appears on all PURLs so that users are more likely to see the additional terms required.

There isn't a standard use and reproduction statement that appears on all Purls. H2 has a standard use and reproduction statement that all H2 deposits use. Anything that goes into the SDR via Argo can have a customized statement (or no statement), and any Argo user who manages that content can edit that statement. Ultimately, the statements created in Argo or via H2 populate the same Cocina field. Argo users of that field have also requested that links and emails could be hyperlinked within the field.

thatbudakguy commented 10 months ago

@andrewjbtw are you aware of cases where links and emails aren't hyperlinked? the code says they should be now, and the one case I checked had an email correctly hyperlinked.

andrewjbtw commented 10 months ago

@thatbudakguy I hadn't kept up with that, thanks! I see hyperlinks now where I'm pretty sure I did not before.

thatbudakguy commented 9 months ago

moving this to mods-display, since there's theoretically no work to do in purl itself.