sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.
Other
2 stars 5 forks source link

Investigate why <dl> are not rendered by default #158

Closed thatbudakguy closed 8 months ago

thatbudakguy commented 9 months ago

https://github.com/sul-dlss/purl/issues/786 indicates that it's possible for downstream consumers of this gem to accidentally neglect to render a containing <dl>. that leads to the question of why we don't just render the <dl> in this gem in the first place...potentially because we needed finer-grained control over rendering in a consuming app?

we probably need to do some investigation in purl, searchworks, exhibits, etc. to see if we can find:

if we can't find the latter, we may as well move the <dl> rendering into this gem and update the consumers.

cbeer commented 9 months ago

I think we don't want <dl> by default because downstream apps group different values into different arrangements of <dl>s?

thatbudakguy commented 9 months ago

yeah, that's what I was getting at with the second bullet above. I assumed that must happen somewhere, I just didn't know which apps & why

justinlittman commented 8 months ago

@thatbudakguy Is there anything actionable on this ticket or can it be closed? (I believe this problem is now fixed in PURL as part of the new design.)

thatbudakguy commented 8 months ago

closing it, since we answered the question