refactor: Field now uses @stanford_mods_element instead of @values

sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.

Other

2 stars 5 forks source link

refactor: Field now uses @stanford_mods_element instead of @values #166

Closed ndushay closed 8 months ago

ndushay commented 8 months ago

closes #164

looks big, but the changes are very simple.

Addresses:

how does Field @values get populated? (answered with comment) <-- this is a key part of this gem
what are the objects that are @values? (answered with better variable name) <-- this is also a key part of this gem
is there a difference between Field @values and ModsDisplay::Values @values? (answered with better variable name and class comment for ModsDisplay::Values)

corylown commented 8 months ago

@ndushay there are some conflicts that need to be resolved before this can be merged. But I can approve/merge this once those are resolved. Thank you.

jcoyne commented 8 months ago

Just a heads up that this could be a breaking change for any downstream that uses the @values ivar.