search

sul-dlss / mods_display

MODS Display is a gem to centralize the display logic of MODS medadata.
Other
2 stars 5 forks source link

use roleTerm (code or text) as the display label and remove role after name #49

Closed drh-stanford closed 6 years ago

drh-stanford commented 6 years ago

This PR is connected to https://github.com/sul-dlss/exhibits/issues/936. It changes how roles are handled. See the screenshots below, and the algorithm defined in https://github.com/sul-dlss/exhibits/issues/936#issuecomment-346491869.

Before (fs947tw3404)

33148601-4e507f70-cf81-11e7-819c-bbe27a9f6457

After (fs947tw3404)

screen shot 2017-11-27 at 2 04 33 pm

After (vn199zb9806)

screen shot 2017-11-27 at 3 03 04 pm