search

sul-dlss / pre-assembly

Rails app - prepares objects for assembly workflow and allows discovery report
https://consul.stanford.edu/display/chimera/Automated+Accessioning+and+Object+Remediation+%28pre-assembly+and+assembly%29
Other
1 stars 2 forks source link

rename stimulus controller from ocr to caption #1525

Closed peetucket closed 1 month ago

peetucket commented 1 month ago

Why was this change made? 🤔

We will be adding speech to text code to this stimulus controller, so this makes the name more encompassing.

How was this change tested? 🤨

Localhost and CI

peetucket commented 1 month ago

feels like "text extraction" would be more in line with the terminology we settled on than "caption", but since it looks like this did end up being a pretty straightforward find-and-replace, and since it's not really any less work to rename again in a follow up PR, i'm just going to merge. maybe post-standup topic monday if i care enough to remember to bring it up? 😆

as I was doing this, I kept thinking, why doesn't "caption" feel like the correct name??? (i had "speech to text" in my brain and knew that wasn't correct)

I am now far along the path of adding speech to text stuff which is based on this, but we can come back later when that is all done and do another controller rename for consistency if we want