search

sul-dlss / sdr-client

SDR API client (in Ruby)
https://sul-dlss.github.io/sdr-api/
Other
0 stars 1 forks source link

add service_name field to DirectUploadResponse #146

Closed jmartin-sul closed 3 years ago

jmartin-sul commented 3 years ago

Why was this change made?

the upgrade to rails 6.1 in sdr-api added a new column to the active_storage_blobs table. sdr-api is sending this back in the response for file uploads, and since the field wasn't declared in the DirectUploadResponse Struct, it was causing an error when attempting to instantiate DirectUplaodResponse from the actual updated sdr-api responses.

How was this change tested?

unit tests, integration tests (using this branch of sdr-client in the integration test suite, as well as a stage deployment of H2 which uses this branch of sdr-client).

see also: https://github.com/sul-dlss/happy-heron/pull/801 https://github.com/sul-dlss/infrastructure-integration-test/pull/189

Which documentation and/or configurations were updated?

n/a

jmartin-sul commented 3 years ago

questions:

  1. should sdr-client be sending service_name along to sdr-api with the file metadata it builds?
  2. if so, should that happen in this PR, or can it happen in a follow on?