Closed jcoyne closed 2 years ago
Currently we make all the upload requests before uploading any file. https://github.com/sul-dlss/sdr-client/blob/8b10568b690b02093e13ee825792314664fd94e7/lib/sdr_client/deposit/upload_files.rb#L38
if the uploads themselves take a long time and there are many of them, the tickets we created may have expired before the upload can begin.
We saw this in https://github.com/sul-dlss/happy-heron/issues/2056
We've worked around this by increasing the timeout in SDR-API, (https://github.com/sul-dlss/sdr-api/commit/3c32de7fe75dc22260771bdc9738615c56ce94c4) but a better solution would be to interleave the upload request and the upload.
Currently we make all the upload requests before uploading any file. https://github.com/sul-dlss/sdr-client/blob/8b10568b690b02093e13ee825792314664fd94e7/lib/sdr_client/deposit/upload_files.rb#L38
if the uploads themselves take a long time and there are many of them, the tickets we created may have expired before the upload can begin.
We saw this in https://github.com/sul-dlss/happy-heron/issues/2056
We've worked around this by increasing the timeout in SDR-API, (https://github.com/sul-dlss/sdr-api/commit/3c32de7fe75dc22260771bdc9738615c56ce94c4) but a better solution would be to interleave the upload request and the upload.