search

sul-dlss / sdr-client

SDR API client (in Ruby)
https://sul-dlss.github.io/sdr-api/
Other
0 stars 1 forks source link

Bump connection timeouts higher #200

Closed mjgiarlo closed 2 years ago

mjgiarlo commented 2 years ago

Why was this change made? 🤔

Connects to sul-dlss/happy-heron#2200

We need to bump the timeouts to be able to upload multiple large files serially. I gradually bumped this number up from 360 to 900 until I found values that worked for multiple ~10GB files. 900 turned out to be the magic number.

How was this change tested? 🤨

CI and tested in prod

jcoyne commented 2 years ago

Do you know if read_timeout is still used?

mjgiarlo commented 2 years ago

@jcoyne 💬

Do you know if read_timeout is still used?

It seems to be, if I'm looking in the right place. E.g.: https://github.com/lostisland/faraday/blob/498f6027a18df15561723da8d6cb10288a24bf64/lib/faraday/adapter.rb#L75-L99 and https://github.com/lostisland/faraday/blob/21ac595919b0372b41386ae00640e16f73a20d31/lib/faraday/options/request_options.rb#L6

If you concur, merge? If not, I can revise though it may be tough to test since the giant data set's already through.