sul-dlss / searchworks_traject_indexer

indexing MARC, MODS, and more for SearchWorks
Other
6 stars 1 forks source link

Report indexing to SDR based on traject writer #1321

Open thatbudakguy opened 6 months ago

thatbudakguy commented 6 months ago

There are cases where the SdrEvents reporter can report that indexing succeeded even if the request to solr didn't happen or failed. In order to avoid that, we should move the call site for the report_indexing_success method into the SolrBetterJsonWriter (maybe by allowing it to accept an optional reporter class/object).

This applies to deletes (report_indexing_deleted) too, since they imply successful communication with solr.

thatbudakguy commented 6 months ago

Alternatively, we could only report when we know something failed. Then we'd never be lying...