There are cases where the SdrEvents reporter can report that indexing succeeded even if the request to solr didn't happen or failed. In order to avoid that, we should move the call site for the report_indexing_success method into the SolrBetterJsonWriter (maybe by allowing it to accept an optional reporter class/object).
This applies to deletes (report_indexing_deleted) too, since they imply successful communication with solr.
There are cases where the
SdrEvents
reporter can report that indexing succeeded even if the request to solr didn't happen or failed. In order to avoid that, we should move the call site for thereport_indexing_success
method into theSolrBetterJsonWriter
(maybe by allowing it to accept an optional reporter class/object).This applies to deletes (
report_indexing_deleted
) too, since they imply successful communication with solr.