search

sul-dlss / sul-requests

Rails application for requesting materials from Stanford University Library
Other
4 stars 0 forks source link

[sul-requests/prod] NoMethodError: undefined method `reading_room_url' for nil:NilClass #1885

Open jcoyne opened 11 months ago

jcoyne commented 11 months ago

Backtrace

line 18 of [PROJECT_ROOT]/app/views/aeon_pages/_info_modal.html.erb: _app_views_aeon_pages__info_modal_html_erb__3053673931116485696_86480
line 2 of [PROJECT_ROOT]/app/views/aeon_pages/new.html.erb: _app_views_aeon_pages_new_html_erb__3525970063671533706_86460

View full backtrace and more info at honeybadger.io

jcoyne commented 11 months ago

It looks like this was removed https://github.com/sul-dlss/sul-requests/commit/79411dd8460ecddeebc2f79f8052f383e4134155#diff-e769bbb8c1ba3711c5403b424ed9c218ffafba7f1890ee394717196f28ff4540L285

hudajkhan commented 11 months ago

"RUMSEYMAP" was removed as a whole b/c the new library code is "RUMSEY-MAP". I can put it back in with a pointer to the current code, but before I do that, I'll try and see why the old "RUMSEY-MAP" code is being used anyway (and remove it there if possible).

hudajkhan commented 11 months ago

And also not have the page just die.

hudajkhan commented 11 months ago

So this is still requesting using the old "RUMSEYMAP" library code: https://searchworks.stanford.edu/view/14357260, which explains where that code is coming in from.

hudajkhan commented 11 months ago

@cbeer is reverting the original PR for now.