sul-dlss / sul-requests

Rails application for requesting materials from Stanford University Library
Other
4 stars 0 forks source link

Attention needed in mailer, with no information for user on how to fix it #1907

Closed saseestone closed 1 month ago

saseestone commented 1 year ago

Need to figure out all the scenarios when we are showing this to the user, and if we can give the user better information.

Formatting of the "attention needed" in the body of the email is not great. More details coming...

saseestone commented 1 year ago

Jira issues where this is reported:

Scenarios reported, but shouldn't happen after we move Hold/Recall request types to ILLiad:

Based on errors today, Chris saw in the logs that we might see issues for On Order items. Error reason is: "Cannot create page TLR for this instance ID - no pageable available items found", but Chris verified we're sending a title level hold request at the instance level. So we need to figure out why FOLIO is erroring with a message about paging an item.

Also in errors from today, we saw reason: "This requester already has an open request for this instance", we should show a message to the user in the body of the confirmation mailer.

Text forthcoming for all these scenarios...

saseestone commented 1 year ago

For reason "This requester already has an open request in this instance"

For "Page requests are not allowed for this patron and item combination"

Still trying to assess if there are more scenarios that we need to account for.

saseestone commented 1 month ago

Closing this issue since it pre-dates the Requests 2024 workcycle, and we're handling this another way.