Use the sponsor's patron id when submitting requests to FOLIO

sul-dlss / sul-requests

Rails application for requesting materials from Stanford University Library

Other

4 stars 0 forks source link

Use the sponsor's patron id when submitting requests to FOLIO #2435

Closed cbeer closed 5 months ago

cbeer commented 6 months ago

Normal requests use the requesting patron's id (or the destination's pseudopatron.)
Requests for a sponsor (shared with their proxy group) should use the patron's id with a request comment that their proxies can pick it up
Requests by a proxy on behalf of a sponsor should be placed using the sponsor's patron id.

hudajkhan commented 5 months ago

@cbeer When I try this out for http://localhost:3000/patron_requests/new?instance_hrid=1485586&origin_location_code=SAL3-STACKS, I get the following error: ArgumentError (wrong number of arguments (given 0, expected 1)):

| app/models/patron_request.rb:572:in include?' | app/models/patron_request.rb:572:infor_sponsor_id_is_valid' | app/controllers/patron_requests_controller.rb:27:in `create'

hudajkhan commented 5 months ago

I was logged in as Piper Proxy and picked Shea Sponsor as the sponsor (for context)

hudajkhan commented 5 months ago

This might be because the sponsor radio button value is the sponsor name and not the id?

cbeer commented 5 months ago

Thanks, give it another try.

hudajkhan commented 5 months ago

Thanks @cbeer ! Works now. The patron comment reads "(PROXY PICKUP OK; request placed by Piper Proxy hudakhan@stanford.edu)" (which I think is Piper Proxy's current email address).