search

sul-dlss / sul-requests

Rails application for requesting materials from Stanford University Library
Other
4 stars 0 forks source link

Retrieve + display bound-with information #2439

Closed cbeer closed 4 months ago

cbeer commented 5 months ago

and introduce Folio::HoldingsRecord to match FOLIO data structures (and give us a consistent way to get at the normal + bound-with items).

Screenshot 2024-05-09 at 14 35 10

Screenshot 2024-05-09 at 14 36 16

Screenshot 2024-05-09 at 14 36 56

Screenshot 2024-05-09 at 14 37 19

dnoneill commented 5 months ago

Also I think there might be a problem with the call numbers displaying on this page. Looks like there are repeats which I think isn't quite right. http://localhost:3000/patron_requests/new?instance_hrid=387559&origin_location_code=SAL3-STACKS&step=select

cbeer commented 5 months ago

I'm confused by what I'm seeing in folio-test (but not folio-prod?). It looks like the item says it's bound-with itself?

cbeer commented 5 months ago

It looks like this is a FOLIO model change libsys made recently: https://github.com/sul-dlss/folio-tasks/issues/304

I'm not sure I understand what's going on, but it seems safe enough to just make sure we don't have duplicated items and hope for the best? (6bfd9e7)

dnoneill commented 5 months ago

Well that is super weird and not what was there originally but yeah I agree making sure the ids are uniq is probably for the best. I remember we had to do that in the original code for reasons I can't remember.

dnoneill commented 5 months ago

  1. Original specs on this had the language as This item is bound and shelved with: but it has been updated to This item is bound and shelved by:. Was this purposeful?

  2. ~Sorting is off in http://localhost:3000/patron_requests/new?instance_hrid=387559&origin_location_code=SAL3-STACKS&step=select (A 1.34 87 is being added to the end. Probably because this is the bound with).~ (This is an enumeration problem from graphql)

  3. Spacing is a little weird in http://localhost:3000/patron_requests/new?instance_hrid=2969234&origin_location_code=SAL3-STACKS

Screenshot 2024-05-20 at 11 37 29 AM
dnoneill commented 5 months ago

A couple concerns above that could be addressed with this PR or another.

cbeer commented 5 months ago

Original specs on this had the language as This item is bound and shelved with: but it has been updated to This item is bound and shelved by:. Was this purposeful?

I was going off the figmas. I know we went back and forth on what to call this, but I'm not sure what/where the latest decision is. Maybe https://github.com/sul-dlss/sul-requests/issues/1446#issuecomment-1979739635?

Spacing is a little weird I've tweaked the call number wrapping (assuming that's the spacing problem you're noting?)

Screenshot 2024-05-20 at 09 20 14
dnoneill commented 5 months ago

Figmas were probably correct. And yes. That is the spacing problem I was referring to.