search

sul-dlss / sul_pub

SUL system for harvest and managing publications for Stanford CAP, with controlled API access.
http://cap.stanford.edu
Other
8 stars 3 forks source link

allow exported pubs to be filtered; export all authors #1590

Closed peetucket closed 1 year ago

peetucket commented 1 year ago

Why was this change made?

In order to run some new reports for OA analysis, we need to:

(1) Be able to filter publications exported to only specific publication years (2) Be able to filter exported publications to only include approved publications (3) Be able to export publications for all authors

This PR:

(1) Adds a new rake task to dump all authors in the database to CSV. This can then be used an an import to the existing rake task. (2) Modifies the publication export rake task to allow filtering by publication year and publication status.

How was this change tested?

Ran on QA to verify it works as intended.

Which documentation and/or configurations were updated?

peetucket commented 1 year ago

Yes, understood. This rake task is a bit out of control. I think the next change is at least splitting it out into separate rake files that are more organized by function. I believe most (if not all) in this file are just data dumping tasks for reporting purposes, so I'm not sure there is as much value to spending cycles writing tests though (i.e. they are currently run on demand for data dumping for analysis).

ndushay commented 1 year ago

Perhaps make a ticket for this and let someone else do it? Spread the sul-pub knowledge around a little?

Yes, understood. This rake task is a bit out of control. I think the next change is at least splitting it out into separate rake files that are more organized by function. I believe most (if not all) in this file are just data dumping tasks for reporting purposes, so I'm not sure there is as much value to spending cycles writing tests though (i.e. they are currently run on demand for data dumping for analysis).