sul-dlss / sul_pub

SUL system for harvest and managing publications for Stanford CAP, with controlled API access.
http://cap.stanford.edu
Other
8 stars 3 forks source link

update correct active author orcidid #1643

Closed peetucket closed 9 months ago

peetucket commented 9 months ago

Why was this change made?

In some cases an author can have more than one row in the authors table, with one being inactive and the other being active. This sometimes happens if the author had a previous association with Stanford and then wasn't correctly matched up when they joined Stanford again. We have a rake task to merge authors if this happens, but even after we do this, our ORCID update task may still find the inactive author row. This fixes the issue by ensuring we only look for authors with ORCIDs that are active.

Discovered when dealing with a support request for author with a SUNet ID of edehaan who wasn't seeing their publications pushed to ORCID. It turns out it is because they have two author rows and the ones with approved publications and that is marked as active is not that was associated with the ORCID and being found by the push process.

This also updates the "merge authors" rake task to ensure it moves over the ORCID if needed.

I will also manually fix the new correct author row to associate with the ORCID.