sul-dlss / vatican_exhibits

Vatican installation of Spotlight
https://spotlight.vatlib.it
Other
0 stars 1 forks source link

Fix how Names show "role" on item page #383

Closed ggeisler closed 5 years ago

ggeisler commented 5 years ago

BAV has noted that the name display on many item pages does not include the person role when it should. I think the basic case is when there is a name display like this:

Agimundus, sac., sec. VIII [person]

the desired display is this:

Agimundus, sac., sec. VIII [scribe]

where the "scribe" value is taken from the parent <name /> element's role attribute.

There are more details about this in issue #https://github.com/sul-dlss/vatican_exhibits/issues/241#issuecomment-409361755, which is closed, but the last comment in that ticket has a bunch of details that I think are still applicable. If that ticket doesn't explain it let me know.

For the "Agimundus" example above:

TEI: https://digi.vatlib.it/tei/Vat.lat.3835.xml Item page: http://vatican-dev.sul.stanford.edu/latin-paleography/catalog/Vat_lat_3835